Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Julia setup in buildsys, and test Julia GC integration on Travis #2905

Merged
merged 3 commits into from
Oct 9, 2018

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Oct 8, 2018

The Julia GC extension code has now been merged into Julia master, meaning that it is available in Julia nightly builds (and also should be in Julia 1.1, once that gets released).

This now makes it possible to add a Travis job which tests the Julia GC integration in GAP.

Moreover, the Julia integration int the build system was rewritten to make use of julia-config.jl to obtain the correct compiler & linker flags.

@fingolfin fingolfin added topic: tests issues or PRs related to tests do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) labels Oct 8, 2018
@codecov
Copy link

codecov bot commented Oct 8, 2018

Codecov Report

Merging #2905 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2905      +/-   ##
==========================================
+ Coverage   83.74%   83.75%   +<.01%     
==========================================
  Files         680      681       +1     
  Lines      346265   346552     +287     
==========================================
+ Hits       289971   290244     +273     
- Misses      56294    56308      +14
Impacted Files Coverage Δ
src/julia_gc.c 93.63% <ø> (ø)
src/weakptr.c 98.51% <0%> (-0.7%) ⬇️
src/gap.c 84.43% <0%> (+0.09%) ⬆️
src/stats.c 95.47% <0%> (+0.19%) ⬆️
lib/init.g 81.85% <0%> (+0.71%) ⬆️

@fingolfin fingolfin force-pushed the mh/julia-travis branch 4 times, most recently from bfc22ee to 93d371d Compare October 8, 2018 22:40
@fingolfin fingolfin changed the title Test Julia GC integration on Travis (WIP, DO NOT MERGE) Update Julia setup in buildsys, and test Julia GC integration on Travis Oct 8, 2018
@fingolfin fingolfin added topic: build system backport-to-4.9 and removed do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) backport-to-4.9 labels Oct 8, 2018
configure.ac Show resolved Hide resolved
etc/ci-prepare.sh Show resolved Hide resolved
Now configure only checks for a julia binary; then we use julia-config.jl to
determine all relevant paths, and do it all from inside Makefile.rules. The
downside of this is that if we find a broken Julia, this won't work, but
configure won't tell us. The upside is that we get all the correct compiler
and linker flags. In particular, we don't have to hardcode `#define
JULIA_ENABLE_THREADING` anymore.
@fingolfin fingolfin merged commit 482d81f into gap-system:master Oct 9, 2018
@fingolfin fingolfin deleted the mh/julia-travis branch October 9, 2018 09:19
@fingolfin
Copy link
Member Author

Backported via e6b5fc1 and 61cf9ca -- the third commit, which modifies the GAPARCH for Julia, was not (yet?) backported, because it does not apply cleanly, and is not that important for the 4.10 timeline

@fingolfin fingolfin added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Oct 18, 2018
@fingolfin fingolfin removed topic: tests issues or PRs related to tests labels Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-4.10-DONE release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants