-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement List(iter,func) #2960
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2960 +/- ##
==========================================
- Coverage 83.79% 75.05% -8.75%
==========================================
Files 682 624 -58
Lines 346236 311983 -34253
==========================================
- Hits 290135 234162 -55973
- Misses 56101 77821 +21720
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The only nitpick I have is that I think there's no documentation for this (which is a.. "more general problem").
Also, I guess one could expect to have this also for Filtered, Number, ForAll, ForAny, Product, Sum, ... I'll look into resurrecting another branch I made in the past which implements a generic FoldLeft function and reimplements all of the above on top of it, which would make it much easier to implement this atop. |
Regarding documentation, also |
I'll just merge this, everything else can be done in later PRs anyway. |
@mohamed-barakat asked for it during the last GAP Days in September 2018, and now again @markuspf, so I polished up the code I wrote for @mohamed-barakat back then and added some tests.