Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport libgap api to 4.10 #3065

Merged

Conversation

fingolfin
Copy link
Member

This is a backport of all the libgap-api changes done on master, so that these will appear in GAP 4.10.1. I hope this will help folks like @embray who are trying to use this.

Of course we can delay merging this in case people plan to submit more libgap-api changes. Or we just make additional PRs for that.

Note that I had to make some minor modifications to libgap-api.c: We don't have RequireInt in stable-4.10, nor NewPlistFromArray. For the latter, I just added it to libgap-api.c; for the former, I replaced the call by (almost) equivalent code using ErrorMayQuit. For future updates, one needs to retain those (but that's easy enough).

Note: I did not cherry-pick individual PRs modifying libgap-api, as that would have been more work with no clear gain. Nor did I cherry-pick the commit which added NewPlistFromArray, as it also modified several .c files, and while those changes should be harmless, I'd rather go for minimal changes that are guaranteed to not affect code outside libgap-api.c.

@fingolfin fingolfin added topic: kernel release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Nov 28, 2018
@codecov
Copy link

codecov bot commented Nov 28, 2018

Codecov Report

Merging #3065 into stable-4.10 will decrease coverage by 0.03%.
The diff coverage is 17.85%.

@@               Coverage Diff               @@
##           stable-4.10    #3065      +/-   ##
===============================================
- Coverage        76.03%      76%   -0.04%     
===============================================
  Files              482      482              
  Lines           241693   241810     +117     
===============================================
+ Hits            183782   183784       +2     
- Misses           57911    58026     +115
Impacted Files Coverage Δ
src/integer.h 100% <ø> (ø) ⬆️
src/libgap-api.c 12.87% <8.06%> (-80.46%) ⬇️
src/integer.c 92.41% <93.75%> (+0.08%) ⬆️
hpcgap/lib/hpc/stdtasks.g 64.19% <0%> (-0.52%) ⬇️

@dimpase
Copy link
Member

dimpase commented Nov 29, 2018

looks good to me.

Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, IMHO

@embray
Copy link
Contributor

embray commented Nov 29, 2018

Thanks--I have a couple other patches I've been meaning to propose but we can handle those in a followup.

@ChrisJefferson ChrisJefferson merged commit 07b934f into gap-system:stable-4.10 Nov 29, 2018
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.10.1 milestone Nov 29, 2018
@fingolfin fingolfin deleted the mh/backport-libgap-api branch November 29, 2018 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes topic: kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants