Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of all the libgap-api changes done on master, so that these will appear in GAP 4.10.1. I hope this will help folks like @embray who are trying to use this.
Of course we can delay merging this in case people plan to submit more libgap-api changes. Or we just make additional PRs for that.
Note that I had to make some minor modifications to
libgap-api.c
: We don't haveRequireInt
in stable-4.10, norNewPlistFromArray
. For the latter, I just added it tolibgap-api.c
; for the former, I replaced the call by (almost) equivalent code usingErrorMayQuit
. For future updates, one needs to retain those (but that's easy enough).Note: I did not cherry-pick individual PRs modifying libgap-api, as that would have been more work with no clear gain. Nor did I cherry-pick the commit which added
NewPlistFromArray
, as it also modified several .c files, and while those changes should be harmless, I'd rather go for minimal changes that are guaranteed to not affect code outsidelibgap-api.c
.