Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ShallowCopy for KnuthBendixRewritingSystem #3128

Merged
merged 2 commits into from
Jan 7, 2019
Merged

Fix ShallowCopy for KnuthBendixRewritingSystem #3128

merged 2 commits into from
Jan 7, 2019

Commits on Dec 21, 2018

  1. Fix ShallowCopy for KnuthBendixRewritingSystem 

    ShallowCopy did not copy the components `freefam`, `ordering` and `tzordering`
of a KnuthBendixRewritingSystem, and hence cause an error if a rewriting system
was ShallowCopied and used afterwards.
    @ChrisJefferson
    ChrisJefferson authored and Markus Pfeiffer committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    d8aef2a View commit details
    Browse the repository at this point in the history

  2. Fix IsReduced for KnuthBendixRewritingSystem 

    `IsReduced` did not work for KnuthBendixRewritingSystems, because it used
`Rules` to obtain the rules of a rewriting system which are stored as
`IsLetterAssocWordRep`, and then tried reducing words using a kernel function
that assumes list access is possible for such words (which it is not).

Use TzRules instead which converts rules to lists of integers.
    Markus Pfeiffer committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    bf74aa1 View commit details
    Browse the repository at this point in the history