Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Display for functions with large literals, and add a bunch of tests #3207

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Fix Display for functions with large literals, and add a bunch of tests #3207

merged 2 commits into from
Jan 22, 2019

Commits on Jan 22, 2019

  1. Add a bunch of tests to increase coverage 

    Test large float literals, ensure ReadEvalError in function calls
gets reliably triggered, and also test bounds checks for ranges
in gac compiled code.
    @fingolfin
    fingolfin committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    a269208 View commit details
    Browse the repository at this point in the history

  2. Add Display method for functions 

    This fixes a problem where printing functions with long literals would
wrap those literals badly. As an example, before this fix, we got:

    gap> SizeScreen([60,100]);;
    gap> Display(f->12345678901234567890123456789012345678901234567890123456789012345678901234567890);
    function ( f )
        return
         12345678901234567890123456789012345678901234567890123\
    \
    456789012345678901234567890;
    end

With this fix, we get:

    gap> SizeScreen([60,100]);;
    gap> Display(f->12345678901234567890123456789012345678901234567890123456789012345678901234567890);
    function ( f )
        return
         12345678901234567890123456789012345678901234567890123\
    456789012345678901234567890;
    end

Fixes gap-system#3205
    @fingolfin
    fingolfin committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    eb1829c View commit details
    Browse the repository at this point in the history