Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Backtraces with --enable-debug #3209

Merged
merged 2 commits into from
Jan 22, 2019

Conversation

ChrisJefferson
Copy link
Contributor

This enables backtraces when GAP crashes, when GAP is compiled with --enable-debug. This will be (I hope!) particularly useful when GAP crashes on travis.

At the same time I made it so GAP will only print a backtrace when it actually crashes, not just because it was killed, or was terminated.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 84.643% when pulling 00a1020 on ChrisJefferson:backtrace into f56a68c on gap-system:master.

@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

Merging #3209 into master will decrease coverage by 8.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3209      +/-   ##
==========================================
- Coverage   84.76%   76.63%   -8.14%     
==========================================
  Files         687      681       -6     
  Lines      335865   326757    -9108     
==========================================
- Hits       284696   250397   -34299     
- Misses      51169    76360   +25191
Impacted Files Coverage Δ
src/debug.c 29.41% <ø> (-7.44%) ⬇️
src/modules.h 16.66% <0%> (-83.34%) ⬇️
lib/ctbllatt.gi 4.94% <0%> (-79.62%) ⬇️
lib/ctblauto.gi 5.98% <0%> (-78.04%) ⬇️
lib/algliess.gi 5.95% <0%> (-72%) ⬇️
lib/proto.gi 13.4% <0%> (-71.14%) ⬇️
lib/ctblpope.gi 8% <0%> (-69.47%) ⬇️
lib/contfrac.gi 31.42% <0%> (-67.15%) ⬇️
lib/lierep.gi 23.58% <0%> (-62.55%) ⬇️
src/saveload.c 3.3% <0%> (-62.37%) ⬇️
... and 282 more

@fingolfin
Copy link
Member

How does this interact with gdb or lldb?

@fingolfin fingolfin merged commit 9d485d6 into gap-system:master Jan 22, 2019
@ChrisJefferson ChrisJefferson deleted the backtrace branch February 27, 2019 18:01
@PaulaHaehndel PaulaHaehndel added the release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes label Apr 15, 2019
@DominikBernhardt DominikBernhardt added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 22, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants