Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document the two-argument version of Set #3358

Merged
merged 1 commit into from
Mar 20, 2019
Merged

document the two-argument version of Set #3358

merged 1 commit into from
Mar 20, 2019

Conversation

ThomasBreuer
Copy link
Contributor

  • extend the manual section on SSortedList
  • fix the SSortedList method for list and function
    in the case that list is not dense

@ThomasBreuer
document the two-argument version of Set
cc92ba3 
- extend the manual section on `SSortedList`
- fix the `SSortedList` method for list and function
  in the case that list is not dense
@ThomasBreuer ThomasBreuer added topic: documentation Issues and PRs related to documentation release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Mar 19, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.15% when pulling cc92ba3 on ThomasBreuer:TB_2_argument_Set into 7969f32 on gap-system:master.

@fingolfin fingolfin added release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes and removed release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Mar 20, 2019
fingolfin
fingolfin approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

I changed the labels: this PR should be in the release notes, as new functionality has been documented, which users should be notified about (even though the functionality itself is very old)

@fingolfin fingolfin added the gapdays2019-spring Issues and PRs that arose at https://www.gapdays.de/gapdays2019-spring label Mar 20, 2019
@ThomasBreuer ThomasBreuer merged commit a432851 into gap-system:master Mar 20, 2019
@ThomasBreuer ThomasBreuer deleted the TB_2_argument_Set branch March 20, 2019 08:25
@PaulaHaehndel PaulaHaehndel added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Apr 24, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

@ChrisJefferson ChrisJefferson ChrisJefferson approved these changes

Assignees
No one assigned
Labels
gapdays2019-spring Issues and PRs that arose at https://www.gapdays.de/gapdays2019-spring release notes: added PRs introducing changes that have since been mentioned in the release notes topic: documentation Issues and PRs related to documentation
Projects
None yet
Milestone
GAP 4.11.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ThomasBreuer @coveralls @fingolfin @ChrisJefferson @olexandr-konovalov @PaulaHaehndel