Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppVeyor #3377

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Fix AppVeyor #3377

merged 1 commit into from
Mar 25, 2019

Conversation

fingolfin
Copy link
Member

Let's see if this fixes AppVeyor builds (w/o breaking coverage and what not else)

@fingolfin fingolfin added release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: ci Anything related to GitHub Actions, Codecov, AppVeyor, Coveralls, Travis, ... labels Mar 24, 2019
@fingolfin
Copy link
Member Author

That did not help. Now it just dies in the next line:

SET "PATH=%CYG_ROOT%\bin;%PATH%"
bash -lc "python -m pip install gcovr"
Command exited with code 127

Perhaps the path is wrong now, or something else in that vein?

@fingolfin fingolfin changed the title AppVeyor: don't upgrade pip Fix AppVeyor Mar 24, 2019
@codecov
Copy link

codecov bot commented Mar 24, 2019

Codecov Report

Merging #3377 into master will decrease coverage by 15.91%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #3377       +/-   ##
===========================================
- Coverage   85.13%   69.22%   -15.92%     
===========================================
  Files         697      633       -64     
  Lines      344069   305935    -38134     
===========================================
- Hits       292939   211769    -81170     
- Misses      51130    94166    +43036
Impacted Files Coverage Δ
src/pperm.h 0% <0%> (-90.33%) ⬇️
src/tietze.c 1.11% <0%> (-88.99%) ⬇️
src/syntaxtree.c 11.47% <0%> (-88.53%) ⬇️
src/trans.h 0% <0%> (-85.72%) ⬇️
lib/ctblauto.gi 5.98% <0%> (-83.31%) ⬇️
src/vec8bit.c 1% <0%> (-81.63%) ⬇️
src/compiler.c 8.06% <0%> (-80.53%) ⬇️
lib/ctbllatt.gi 4.94% <0%> (-79.62%) ⬇️
src/dteval.c 3.1% <0%> (-78.24%) ⬇️
src/bits_intern.h 0% <0%> (-77.42%) ⬇️
... and 391 more

@fingolfin
Copy link
Member Author

At least part of the problem is that there are two different Python's installed, one by cygwin and one by AppVeyor, and they mix in a bad way...

Copy link
Member

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppVeyor works again!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0006%) to 85.138% when pulling d835c6d on fingolfin:mh/appveyor into 9e7e38d on gap-system:master.

@fingolfin fingolfin merged commit cd3cc79 into gap-system:master Mar 25, 2019
@fingolfin fingolfin deleted the mh/appveyor branch March 25, 2019 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: ci Anything related to GitHub Actions, Codecov, AppVeyor, Coveralls, Travis, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants