-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibGAP API: Add GAP_AssignGlobalVariable
and GAP_CanAssignGlobalVariable
#3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
requested changes
May 6, 2019
fingolfin
added
release notes: to be added
PRs introducing changes that should be (but have not yet been) mentioned in the release notes
topic: kernel
topic: libgap
things related to libgap
labels
May 6, 2019
fingolfin
changed the title
Added GAP_AssignGlobalVariable to libgap-api
LibGAP API: GAP_AssignGlobalVariable added
May 6, 2019
sebasguts
force-pushed
the
sg/libgap-gvars
branch
2 times, most recently
from
May 6, 2019 14:43
7682799
to
8a4817e
Compare
fingolfin
requested changes
May 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #3438 +/- ##
==========================================
- Coverage 85.34% 85.08% -0.27%
==========================================
Files 699 698 -1
Lines 346092 346096 +4
==========================================
- Hits 295374 294468 -906
- Misses 50718 51628 +910
|
fingolfin
reviewed
May 9, 2019
fingolfin
force-pushed
the
sg/libgap-gvars
branch
2 times, most recently
from
May 10, 2019 11:35
f98810c
to
5fec327
Compare
fingolfin
force-pushed
the
sg/libgap-gvars
branch
from
May 10, 2019 13:14
5fec327
to
61fc5b0
Compare
fingolfin
approved these changes
May 11, 2019
fingolfin
changed the title
LibGAP API: GAP_AssignGlobalVariable added
LibGAP API: Add May 11, 2019
GAP_AssignGlobalVariable
and GAP_CanAssignGlobalVariable
Thank you for updating and merging :) |
fingolfin
added
backport-to-4.10
backport-to-4.10-DONE
and removed
backport-to-4.10
labels
Jun 4, 2019
olexandr-konovalov
added
release notes: added
PRs introducing changes that have since been mentioned in the release notes
and removed
release notes: to be added
PRs introducing changes that should be (but have not yet been) mentioned in the release notes
labels
Jun 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-to-4.10-DONE
release notes: added
PRs introducing changes that have since been mentioned in the release notes
topic: kernel
topic: libgap
things related to libgap
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
GAP_AssignGlobalVariable
andGAP_IsNameOfWritableGlobalVariable
to the libgap API, to assign a global variable to a value and check if a name belongs to a writable gvar.Text for release notes
LibGAP API:
GAP_AssignGlobalVariable
andGAP_IsNameOfWritableGlobalVariable
addedFurther details
If necessary, please provide further details here.
Checklist for pull request reviewers
If your code contains kernel C code, run
clang-format
on it; thesimplest way is to use
git clang-format
, e.g. like this (don'tforget to commit the resulting changes):
usage of relevant labels
release notes: not needed
orrelease notes: to be added
bug
orenhancement
ornew feature
stable-4.X
add thebackport-to-4.X
labelbuild system
,documentation
,kernel
,library
,tests
runnable tests
adequate pull request title
well formulated text for release notes
relevant documentation updates
sensible comments in the code