WIP: Add IsDirectProductDomain objects and related basic methods
#3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssiccha
added
kind: new feature
release notes: to be added
ssiccha
changed the title
IsDirectProductDomain objects related basic functionsIsDirectProductDomain objects and related basic methods
|
This PR includes the three commits from PRs #3473, #3468, #3455 in order for the tests to work. I still need to write documentation for I didn't add implementations for |
|
My goal is to be able to define direct products of mappings. For this I need to be able to construct direct products of domains first. |
ssiccha
added
the
do not merge
ssiccha
force-pushed
the
ss/add-DirectProductDomain
branch
from
a899104 to
ea4aa40
Compare
Codecov Report
|
|
|
ssiccha
force-pushed
the
ss/add-DirectProductDomain
branch
from
ea4aa40 to
63fe2c9
Compare
ssiccha
force-pushed
the
ss/add-DirectProductDomain
branch
from
63fe2c9 to
13d0b46
Compare
ssiccha
force-pushed
the
ss/add-DirectProductDomain
branch
from
13d0b46 to
8be2984
Compare
ssiccha
force-pushed
the
ss/add-DirectProductDomain
branch
2 times, most recently
from
97c6d0c to
f78ad27
Compare
... some related functions, operations, attributes, and methods.
TODO
- doc
- examples
- maybe put the "move DirectProductFamily around" part into its own
commit?
Creates new files `lib/productdomain.g{d,i}`, `tst/testinstall/productdomain.tst`.
Moves the declaration, definition, and tests of `DirectProductFamily` from
`lib/tuples.g{d,i}` and `hpcgap/lib/tuples.gi` into the new files.
Adds the new files to `doc/ref/makedocreldata.g` and to `read3.g` and
`read5.g`.
Adds:
- a filter IsDirectProductDomain
- an operation DirectProductDomain to create IsDirectProductDomain
domains and methods for DirectProductDomain
- attributes and methods for IsDirectProductDomain objects:
- ComponentsOfDirectProductDomain, this defines the domain
- DimensionOfDirectProductDomain, the number of components
- PrintObj
- Size
- \in
ssiccha
force-pushed
the
ss/add-DirectProductDomain
branch
from
f78ad27 to
0f86f3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib: add IsDirectProductDomain objects and ...
... some related functions, operations, attributes, and methods.
TODO
Creates new files
lib/productdomain.g{d,i},tst/testinstall/productdomain.tst.Moves the declaration, definition, and tests of
DirectProductFamilyfromlib/tuples.g{d,i}andhpcgap/lib/tuples.giinto the new files.Adds the new files to
doc/ref/makedocreldata.g.Adds:
domains and methods for DirectProductDomain