Add GET_FROM_SORTED_CACHE helper; use it to unify hpcgap/lib/ffe.gi, hpcgap/lib/pcgsperm.gi, hpcgap/lib/zmodnz.gi #3515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of sorting from scratch, use the insertion position that we computed anyway. To this end, call POSITION_SORTED_LIST directly instead of Position.
Fixes gap-system#1930 (HPC-GAP: CYCLICACHE cache in CreateIsomorphicPcGroup is racy)
fingolfin
added
topic: HPC-GAP unification
topic: library
release notes: not needed
ChrisJefferson
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this changes how the undocumented variables
GALOIS_FIELDSandCYCLICACHEwork. But I verified that no package access them (as it should be). I also think that the new caching approach is not really worse than the old in both cases (the memory overhead is slightly larger forCYCLICACHE).This could be considered a small step towards resolving issue #1889, but of course the primitive data structure employed here is not exactly ideal. But I decided that instead of waiting for a hypothetical better implementation that may never come, I wanted to have some progress now, so that for fixing issues in
zmodnz.gi, I don't have to remember editing two files.