-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added IsNonabelianSimpleGroup
; removed bad implication IsSimpleGroup => IsAlmostSimpleGroup
#3522
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3522 +/- ##
===========================================
- Coverage 85.45% 73.44% -12.02%
===========================================
Files 696 534 -162
Lines 344887 267375 -77512
===========================================
- Hits 294739 196370 -98369
- Misses 50148 71005 +20857
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is a good idea. I'd do it slightly differently, though, see suggestions.
I fixed the diff in the manual, tests are running again |
The Travis build has passed but GitHub doesn't seem to have realised, so I can't merge. |
eab81b1
to
f9bf77e
Compare
I've included the last suggestion and rebases, lets hope (indeed it did) Travis complies. |
and use it in library wherever this is intended in place of `IsSimpleGroup`.
IsNonabelianSimpleGroup
IsNonabelianSimpleGroup
; removed bad implication IsSimpleGroup => IsAlmostSimpleGroup
and use it in library wherever this is intended in place of
IsSimpleGroup
.There were places in the code which uses
IsSimpleGroup
intending nonabelian simple. While thy did not cause obvious errors, it is cleaner to use a dedicated filter and will also inherit theIsAlmostSimpleGroup
implication.Release Notes:
Clarified definition and use of
IsSimpleGroup
to allow for abelian simple groups and introducedIsNonabelianSimpleGroup
.