Fix ViewString
for string to correctly escape characters needing it
#3693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2884
This fixes ViewString not correctly escaping strings. This is done by making the function which prints strings to the terminal generic, so we can print a string (with escape characters) to a buffer.
Note that, to make the kernel level stuff easier, I print to a plist of strings which have to be concatenated together, which then actually gets done back at the GAP level. If this offends anyone I could make a growing string and do this in one go, but this seemed easier.