Fix ConstituentsOfCharacter for Brauer character #3733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The variant of `ConstituentsOfCharacter` with only argument a Brauer character was wrong, it regarded the character as an ordinary character. (This bug has been reported by Gabriel Navarro.) - Also the case of a virtual Brauer character was not handled correctly. The two bugs are now fixed, some tests for the variants of arguments are available, and the documentation states which cases are admissible: ordinary or modular characters, ordinary of modular virtual characters. Also, the documentation
ThomasBreuer
added
kind: bug: wrong result
|
Backported to stable-4.11 in commit d394a71 |
fingolfin
changed the title
fingolfin
added
kind: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The two bugs mentioned in the text for release notes (see below) are now fixed,
some tests for the variants of arguments are available,
and the documentation states which cases are admissible:
ordinary or modular characters,
ordinary or modular virtual characters.
Text for release notes
The result of
ConstituentsOfCharacter, when called with a Brauer character as its only argument, was not reliable.(This bug has been reported by Gabriel Navarro.)
Also, calling
ConstituentsOfCharacterwith a Brauer character table and a virtual Brauer character caused error messages.