Add a new kernel header gap_all.h
for use by package authors instead of compiled.h
#3745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, most package kernel extensions
#include "compiled.h"
in orderto conveniently get access to (almost) all source headers of GAP at once
(which is nice for us because it means we are free to rename headers or
move stuff around between them without breaking kernel extensions).
But the result is rather counterintuitive: if one is not familiar with
this, seeing
#include "compiled.h"
in code is not at all clear. Also,the original of
compiled.h
was to be included by C code generated bygac
, and it contains stuff we'd rather not encourage others to use.Thus, add a new header
gap_all.h
containing all#include
statementsformerly found in
compiled.h
-- this resolves all concerns.Of course it will take time for kernel extensions to switch to this new header, especially if they care about staying compatible with older GAP versions. But the sooner we add this, the sooner such a switch could happen. Hence it would be nice to backport this (any objections).