Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow package build systems to detect GAP version by inserting GAP_VERSION into sysinfo.gap #3746

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Nov 18, 2019

This is useful for package build systems which want to verify the GAP version. If GAP_VERSION is missing, then the package knows it is dealing with GAP <= 4.10.x

This is a minor change but potentially quite useful for packages, yet clearly won't interfere with anything badly, so I'd really like to backport it. At the same time, it is relevant for package authors, so I'd like to mention it in the release notes, together with other stuff relevant for package authors.

This is useful for package build systems which want to verify
the GAP version.
@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: build system release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes backport-to-4.11 labels Nov 18, 2019
@coveralls
Copy link

coveralls commented Nov 18, 2019

Coverage Status

Coverage increased (+0.008%) to 84.521% when pulling 8221038 on fingolfin:mh/sysinfo-version into b5b9381 on gap-system:master.

@ChrisJefferson ChrisJefferson merged commit 77a7c42 into gap-system:master Nov 19, 2019
@fingolfin fingolfin deleted the mh/sysinfo-version branch November 20, 2019 13:58
@fingolfin
Copy link
Member Author

Backported to stable-4.11 as f1f5dc5

@fingolfin fingolfin changed the title Insert GAP_VERSION into sysinfo.gap Allow package build systems to detect GAP version by inserting GAP_VERSION into sysinfo.gap Nov 28, 2019
@fingolfin fingolfin added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Dec 5, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-4.11-DONE kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes topic: build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants