Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to simple group generation/iteration #3790

Merged
merged 2 commits into from
Dec 20, 2019
Merged

Improvements to simple group generation/iteration #3790

merged 2 commits into from
Dec 20, 2019

Conversation

hulpke
Copy link
Contributor

@hulpke hulpke commented Dec 19, 2019 •
edited by PaulaHaehndel
Loading

Description

Added generators for 3D4(q), Order formula for G(q)
Better handling of outer automorphism structure for D(q) in DataAboutSimpleGroups
Cleanup in parsing names of type O+-

Text for release notes

Added further information to the library of simple groups

@hulpke hulpke added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Dec 19, 2019
wilfwilson
wilfwilson approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a nice collection of improvements, thanks. My only request would that you'd add a test or two, at least to include the creation of one of these new 3D4(q) groups (and possibly to have a test showing the order of a G(q) group).

grp/simple.gi
return G;
end);

# generators from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment, it's handy.

grp/simple.gi Show resolved Hide resolved
grp/simple.gi Show resolved Hide resolved
@wilfwilson
Copy link
Member

(Note that the Travis tests will currently fail (see #3788) so we'll eventually ask you to rebase on master once the problems in the master branch are fixed.)

@fingolfin
Copy link
Member

Travis tests on master should be fixed now, please rebase this PR to re-run the tests.

@fingolfin
Copy link
Member

Actually, there is also a test "failure", which however is easy enough (and satisfying ;-) to fix;

testing: /cygdrive/c/projects/gap/tst/testinstall/opers/SimpleGroup.tst
########> Diff in /cygdrive/c/projects/gap/tst/testinstall/opers/SimpleGroup.tst:292
# Input is:
SimpleGroup("3D(4,4)");
# Expected output:
Error, Can't do yet
# But found:
3D4(4)
########
    9360 ms (205 ms GC) and 129MB allocated for opers/SimpleGroup.tst

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 84.686% when pulling a404eb7 on hulpke:fixes into 709264a on gap-system:master.

@hulpke hulpke merged commit ac4a680 into gap-system:master Dec 20, 2019
@fingolfin fingolfin mentioned this pull request Jan 29, 2020
Merged
fingolfin pushed a commit that referenced this pull request Jan 29, 2020
@hulpke @fingolfin
Improvements to simple group generation/iteration (#3790)
c4832e1 
FIX/ENHANCE: Better treatment of creating/handling data for some groups:

Better handling of automorphisms of groups of type O+-
Added (matrix generators) for 3D4(q)
Added order formula for G(q)
@fingolfin
Copy link
Member

Backported to stable-4.11 in commit c4832e1

@PaulaHaehndel PaulaHaehndel self-assigned this Feb 17, 2021
@PaulaHaehndel PaulaHaehndel added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 17, 2021
@PaulaHaehndel PaulaHaehndel removed their assignment Feb 17, 2021
@olexandr-konovalov olexandr-konovalov mentioned this pull request Feb 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilfwilson wilfwilson wilfwilson approved these changes

Assignees
No one assigned
Labels
backport-to-4.11-DONE kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hulpke @wilfwilson @fingolfin @coveralls @PaulaHaehndel