Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some crashes caused by running out of memory #3825

Merged
merged 6 commits into from
Jan 7, 2020
Merged

Fix some crashes caused by running out of memory #3825

merged 6 commits into from
Jan 7, 2020

Conversation

fingolfin
Copy link
Member

This is a variant of PR #3793 by @ChrisJefferson , rebased onto PR #3812, and with several of my remarks on PR #3793 addressed.

Closes #3793
Fixes #3297
Fixes #3786

I am also happy to close this if @ChrisJefferson prefers to update his PR!

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: crash Issues describing bugs that cause GAP to crash, and PRs fixing them (used for release notes) topic: kernel release notes: added PRs introducing changes that have since been mentioned in the release notes labels Jan 2, 2020
@coveralls
Copy link

coveralls commented Jan 2, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.002%) to 84.729% when pulling a8f0885 on fingolfin:mh/mem-full into 26d49af on gap-system:master.

ChrisJefferson
ChrisJefferson reviewed Jan 6, 2020
View reviewed changes
src/gasman.c Outdated Show resolved Hide resolved
fingolfin and others added 5 commits January 6, 2020 23:31
@fingolfin
kernel: cleanup in CollectBags even if there was an error
b503d7b
@ChrisJefferson @fingolfin
Add functionality to stop 'SyStorMax limit exceeeded' message
e58aba9 
This is needed because when GAP completely fills memory, we do
not want the error for 'memory full' and 'SyStorMax limit' to
both appear.
@ChrisJefferson @fingolfin
Make CollectBags return 0 when it cannot allocate enough space
65bb532 
Previously CollectBags would sometimes return 0, and sometimes
Panic. Also, cleanup was not handled properly
@ChrisJefferson @fingolfin
Make GASMAN enter the break loop when a large allocation fails
b48ab38
@ChrisJefferson @fingolfin
Add tests for GAP running out of memory
a8f0885
@fingolfin fingolfin merged commit eef306a into gap-system:master Jan 7, 2020
@fingolfin fingolfin mentioned this pull request Jan 7, 2020
Closed
@fingolfin fingolfin deleted the mh/mem-full branch January 7, 2020 08:45
@olexandr-konovalov olexandr-konovalov mentioned this pull request Feb 19, 2021
Closed
@olexandr-konovalov olexandr-konovalov mentioned this pull request Mar 23, 2021
Merged
@fingolfin fingolfin changed the title Handle out of memory errors better (variant of PR #3793) Handle out of memory errors better Aug 17, 2022
@fingolfin fingolfin changed the title Handle out of memory errors better Fix some crashes caused by running out of memory Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisJefferson ChrisJefferson ChrisJefferson approved these changes

@wilfwilson wilfwilson Awaiting requested review from wilfwilson

Assignees
No one assigned
Labels
kind: bug: crash Issues describing bugs that cause GAP to crash, and PRs fixing them (used for release notes) kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel
Projects
None yet
Milestone
No milestone
3 participants
@fingolfin @coveralls @ChrisJefferson