Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of GMP from version 6.1.2 (December 2016) to version 6.2.0 (January 2020) #3912

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

fingolfin
Copy link
Member

We had 6.1.2 before, released in December 2016. This new version was released January 2020.

@fingolfin fingolfin added topic: build system release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Mar 2, 2020
@stevelinton
Copy link
Contributor

There may be a problem with Macs. The GMP web page says:

Issues with GMP 6.2.0:
MacOS Xcode 11 prior to 11.3 miscompiles GMP, leading to crashes and miscomputation.
Issues with GMP 6.1.2:
MacOS Xcode 11 prior to 11.3 miscompiles GMP, leading to crashes and miscomputation.

The affected versions of Xcode came out between Sep and Dec 2019. Anyone who got a new Mac or upgraded their OS in that interval and hasn't install the (inevitably huge) upgrade to Xcode will be affected.

@coveralls
Copy link

coveralls commented Mar 2, 2020

Coverage Status

Coverage remained the same at 84.779% when pulling 384cc7d on fingolfin:mh/gmp-6.2.0 into b068bb1 on gap-system:master.

@fingolfin
Copy link
Member Author

But as you write, this affects both version 6.1.2 which we are using right now, and also the new version 6.2.0. So this problem is orthogonal to this PR, isn't it?

Somebody might still want to implement a change to our buildsystem to check for the problematic Xcode versions...

@stevelinton
Copy link
Contributor

@fingolfin Fair point. The bug may well be in parts of GMP we don't use.

Copy link
Contributor

@stevelinton stevelinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, the only possibly concerning problem in 6.2 is already present in 6.1.2.

@ChrisJefferson ChrisJefferson merged commit 5c65ed9 into gap-system:master Mar 16, 2020
@fingolfin fingolfin deleted the mh/gmp-6.2.0 branch March 17, 2020 01:45
@danielrademacher danielrademacher self-assigned this Feb 16, 2021
@danielrademacher danielrademacher changed the title Update GMP to version 6.2.0 Update of GMP from version 6.1.2 (December 2016) to version 6.2.0 (January 2020) Feb 16, 2021
@danielrademacher danielrademacher added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 16, 2021
@danielrademacher danielrademacher removed their assignment Feb 16, 2021
@fingolfin fingolfin added release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes and removed release notes: added PRs introducing changes that have since been mentioned in the release notes labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants