Fix a long standing bug which prevented SetPrintFormattingStatus( "*stdout*", false ); from working as expected
#4132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: kernel
release notes: not needed
fingolfin
force-pushed
the
mh/remove-output-stack
branch
3 times, most recently
from
28da470
to
11c0b93
Compare
fingolfin
commented
Oct 14, 2020
Comment on lines
+1874
to
+1879
| TypOutputFile * output = IO()->Output; | ||
| if (!output) | ||
| ErrorMayQuit("SET_PRINT_FORMATTING_STDOUT called while no output is opened\n", 0, 0); | ||
| while (output->prev) | ||
| output = output->prev; | ||
| output->format = (val != False); |
There was a problem hiding this comment.
As an accidental byproduct, this change also fixes #1308
wilfwilson
approved these changes
Oct 15, 2020
fingolfin
force-pushed
the
mh/remove-output-stack
branch
2 times, most recently
from
b4e50e0
to
8a69634
Compare
Instead of pre-allocating a fixed number of TypOutputFile instances on each thread, we allocate the required storage dynamically on the stack. This arguably makes it easier to reason about the global state of GAP. It also enables future simplifications and improvements, e.g. to fix issues were switching between stdout and errout breaks tracking of the output state, which leads to GAP expecting resp. inserting linebreaks in the wrong spots.
fingolfin
force-pushed
the
mh/remove-output-stack
branch
from
8a69634
to
f762396
Compare
fingolfin
added
release notes: to be added
wilfwilson
approved these changes
Oct 15, 2020
ThomasBreuer
added
release notes: added
fingolfin
changed the title
SetPrintFormattingStatus( "*stdout*", false ); from working as expected
fingolfin
added
the
kind: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of pre-allocating a fixed number of TypOutputFile instances on each thread, we allocate the required storage dynamically on the stack. This arguably makes it easier to reason about the global state of GAP.
It also enables future simplifications and improvements, e.g. to fix issues were switching between stdout and errout breaks tracking of the output state, which leads to GAP expecting resp. inserting linebreaks in the wrong spots.
This includes PR #4122 which should be reviewed and merged first.DONEFixes #1308
Text for release notes: