Fix Cite to honor GAPInfo.TermEncoding for its printing; let BibEntry always use encoding "UTF-8"
#4146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankluebeck
added
the
kind: bug: unexpected error
fingolfin
reviewed
Oct 21, 2020
ThomasBreuer
approved these changes
Oct 21, 2020
ThomasBreuer
added
release notes: not needed
`BibEntry` produces a snippet of XML without processing instruction about its encoding. Therefore the result should be in the default encoding "UTF-8" for our XML parser. Instead `Cite` should use the setting in GAPInfo.TermEncoding for its printing. This commit also improves some details in the code of `Cite`: - indentation of code - normalized spelling of package names - fix of typo
frankluebeck
force-pushed
the
fl_fixencodingBibEntry
branch
from
8c2e2fe
to
eeac3b4
Compare
|
I have added a comment, fixed the typo as suggested, and added a remark to the commit message. |
fingolfin
added
release notes: to be added
wilfwilson
approved these changes
Oct 29, 2020
ThomasBreuer
changed the title
Cite w.r.t. the encoding used; let BibEntry always use encoding "UTF-8".
ThomasBreuer
added
release notes: added
fingolfin
changed the title
Cite w.r.t. the encoding used; let BibEntry always use encoding "UTF-8".Cite to honor GAPInfo.TermEncoding for its prining; let BibEntry always use encoding "UTF-8"
fingolfin
changed the title
Cite to honor GAPInfo.TermEncoding for its prining; let BibEntry always use encoding "UTF-8"Cite to honor GAPInfo.TermEncoding for its printing; let BibEntry always use encoding "UTF-8"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BibEntryproduces a snippet of XML without processing instructionabout its encoding. Therefore the result should be in the default
encoding "UTF-8" for our XML parser.
Instead
Citeshould use the setting in GAPInfo.TermEncoding forits printing.
Before this fix
Citeran into an error in a terminal with, say, latin1 encoding.The fix was tested in terminals with utf8 and with latin1 encoding. I don't see how to add a test for this in the
tstdirectory.Description
see above
Text for release notes
not needed