Fixed bugs in RestrictedPerm with second argument a range.
#4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJefferson
added
kind: bug: wrong result
|
Just to say, we could also change RestrictedPerm to just reject inputs which contain non-positive integers -- while it looked to me like the intention was to support it, I'm now investigating and it looks like it might be more sensible to reject it. |
fingolfin
approved these changes
Nov 17, 2020
ChrisJefferson
force-pushed
the
restricted-perm
branch
from
cfb5160 to
0c883c1
Compare
1) If the list contained negative numbers, () was always returned 2) Ranges with steps which were not = 1 were mishandled
ChrisJefferson
force-pushed
the
restricted-perm
branch
from
0c883c1 to
843b09d
Compare
|
Code now reformatted and simplified somewhere, I now (correctly) just reject negative inputs. Added (possibly too many) tests, to make sure all the various boundary conditions are hit properly. |
fingolfin
approved these changes
Nov 17, 2020
ThomasBreuer
changed the title
RestrictedPerm with second argument a range.
ThomasBreuer
added
release notes: not needed
|
Backported to stable-4.11 via PR #4262 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in RestrictedPerm for handling ranges had a few bugs (I found issue (2) in some code I was working on, when I went to investigate I noticed issue (1))
Rather than try to fix the old code, which was both buggy and confusing, I just wrote a (hopefully) much simpler loop, which I believe will be just as efficient (as the only one wasn't trying to do "clever skipping" anyway.