Fix InvariantQuadraticForm
for Omega(-1, 2*d, 2^n)
#4327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add proper tests to check that the quadratic forms are indeed correct
(the existing tests were too weak).
Fixes #4323
Some background: We didn't even store the
InvariantQuadraticForm
for these groups up to GAP 4.9; it was only added in 4.10, via my PR #2577. In there, I also added tests to verify the quadratic form, but those tests were insufficient (rather obviously so, in retrospect sigh). This adds a test similar to what Thomas used to highlight the issue in his bug report.