Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes in NormalSubgroups and PrintCSV #433

Merged
merged 5 commits into from
Jan 8, 2016
Merged

Conversation

hulpke
Copy link
Contributor

@hulpke hulpke commented Jan 6, 2016

Both should go into the 4.8 branch as well

@ChrisJefferson
Copy link
Contributor

Out of interest, what is the issue with Int? According to the docs it should actually be stronger than your extra condition (it should only accept strings of 0-9, with an optional '-' at the start).

@hulpke
Copy link
Contributor Author

hulpke commented Jan 6, 2016

@ChrisJefferson I was using Int to test whether a string is an integer (relying on an undocumented feature to return `fail' otherwise which does not work any longer with recent changes), so I need to check the argument myself. (The fix is not in Int but in a call to Int).

hulpke added a commit that referenced this pull request Jan 8, 2016
Bug fixes in NormalSubgroups and PrintCSV.

(There is an accidental addition and later delete which somehow made it into the history but not into the files.)
@hulpke hulpke merged commit 947d8bf into gap-system:master Jan 8, 2016
@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants