Forbid installing an operation as method for itself #4349
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggering such a "method" would lead to a segfault due to a stack overflow.
Of course one can still trigger this by e.g. having two operations
foo
andbar, and installing
fooas method for
bar` and vice-versa. But that is farless likely to happen by accident. Also, it seems better to fix at least some
instances of this issue than to give up because we can't fix it completely.
Essentially resolves #4340 and #1286
Blocked by the fact that at least one method (irredsol) actually installs an operation as method for itself, albeit by accident, and in a fashion that should make it impossible for this method to ever be actually triggered in "normal" situations. Still, this PR will cause this to throw an error, so we can't merge it until irredsol gets a new release with a fix, such as bh11/irredsol#10.