Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix autoreconf 2.71 missing some files #4377

Closed
wants to merge 2 commits into from
Closed

Fix autoreconf 2.71 missing some files #4377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1022e2b
Add automake on Mac OS X, required for autoreconf
ChrisJefferson Apr 9, 2021
071e149
Fix autoreconf 2.71 missing some files
ChrisJefferson Apr 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ jobs:
sudo apt-get update
sudo apt-get install "${packages[@]}"
elif [ "$RUNNER_OS" == "macOS" ]; then
brew install gmp readline zlib
brew install gmp readline zlib automake
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No no no! We do not want to pull in automake

else
echo "$RUNNER_OS not supported"
exit 1
Expand Down
5 changes: 5 additions & 0 deletions bin/BuildPackages.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,11 @@ run_configure_and_make() {
if [[ -x autogen.sh && ! -x configure ]]
then
./autogen.sh
# (Hopefully) temporary fix for Autoconf 2.71
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try to simply update config.sub and config.guess, that's something we have to do occasionally anyway (see issue #1478). There are other changes to be made in configure.ac. I'll look into that. But all of this must keep working with autoconf 2.69, which is what almost everyone has. In a quick test of mine, it does so.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue was actually specific to the io package, which actually had a buggy configure.ac that happened to work in autoconf 2.69, and now 2.70 detected it. To be precise: I set it up to not check for a "canonical host type", but then used autoconf macros which actually require that; in autoconf 2.69 this sailed through (and possibly resulted in buggy behavior, though this unlikely on any modern day OS). In autoconf 2.70 it detects this requirement and computes the canonical host type, which require config.guess and config.sub ... hence the issue

if [[ $(which autoreconf) && ! -x config.sub ]]
then
autoreconf -f -i
fi
fi
if [[ -x configure ]]
then
Expand Down