Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection of small fixes and improvements that do not merit an own PR each #4411

Merged
merged 7 commits into from
Apr 20, 2021
Merged

Collection of small fixes and improvements that do not merit an own PR each #4411

merged 7 commits into from
Apr 20, 2021

Conversation

hulpke
Copy link
Contributor

@hulpke hulpke commented Apr 16, 2021 •
edited
Loading

Partial backport of my work branch to master

  • Performance improvement to automorphism group/group isomorphism *
  • Clean away the messy EFactors function in DataAboutSimpleGroup
  • Store Solvability of extensions, if known
  • Have RankAction test transitivity (was requested)
  • FIX: Improvements in how MTC deletes superfluous generators -- avoid error message in ghomomorphisms for FpGroups. *
  • Performance improvement in IntermediateSubgroups if the smaller subgroup has many orbits *

(The ones with * merit mentioning in the release notes)

@hulpke hulpke added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes kind: performance labels Apr 16, 2021
@hulpke hulpke added this to the GAP 4.12.0 milestone Apr 16, 2021
@wilfwilson
Copy link
Member

wilfwilson commented Apr 16, 2021 •
edited
Loading

Thanks @hulpke. I don’t have time to review at the moment, but I’ll note that GitHub renders - and * as the same bullet point icon, so it’s not obvious which ones you mean for release notes. (Update: I added a * to the end of these items 🙂)

@hulpke
Copy link
Contributor Author

hulpke commented Apr 16, 2021

Thank you @wilfwilson (and I was so proud of using two different bullets... :-( )

@hulpke
ENHANCE: Criterion for using radical automorphisms
ac5c7b0 
Restrict on dimensions of all LGLayers, not just the top one.
@hulpke
ENHANCE: Clean away `EFactors' function.
374b566
@hulpke
ENHANCE: Transfer solvability information onto extension.
c50bf51
@hulpke
ENHANCE: RankAction tests transitivity
59ccd67 
since it can be done at low cost in this particular case.
This resolves gap-system#4370
@hulpke
FIX: MTC will do better work in deleting superfluous generators.
93568a8 
This resolves gap-system#4406
@hulpke
ENHANCE: IntermediateSubgroups performance
b78dc2e 
Abvoid getting bugged down in trying to match many short orbits of a subgroup.
Added function to find nonnegative solutions of linear diophantine equation.
Moved combinatorial function into combinat.gi
wilfwilson
wilfwilson approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me.

lib/ghomfp.gi Outdated Show resolved Hide resolved
@hulpke @wilfwilson
Update lib/ghomfp.gi
ed322bb 
Co-authored-by: Wilf Wilson <wilf@wilf-wilson.net>
@hulpke hulpke merged commit c576931 into gap-system:master Apr 20, 2021
@fingolfin fingolfin added topic: performance bugs or enhancements related to performance (improvements or regressions) and removed kind: performance labels Apr 21, 2021
@fingolfin fingolfin added release notes: multiple PRs introducing changes that require multiple entries in the release notes (TO BE AVOIDED!!!) release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilfwilson wilfwilson wilfwilson approved these changes

Assignees
No one assigned
Labels
kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes release notes: multiple PRs introducing changes that require multiple entries in the release notes (TO BE AVOIDED!!!) topic: performance bugs or enhancements related to performance (improvements or regressions)
Projects
None yet
Milestone
GAP 4.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hulpke @wilfwilson @fingolfin