Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove an irritating if statement in MethodsOperation #4413

Merged
merged 1 commit into from
Apr 20, 2021
Merged

remove an irritating if statement in MethodsOperation #4413

merged 1 commit into from
Apr 20, 2021

Conversation

ThomasBreuer
Copy link
Contributor

The component location in the records returned by MethodsOperation is always bound.
Note that the check before the definition of MethodsOperation guarantees that the list returned by METHODS_OPERATION has the right format.

@ThomasBreuer ThomasBreuer added topic: library release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes kind: general proposed change labels Apr 17, 2021
fingolfin
fingolfin approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. This is from a time when BASE_SIZE_METHODS_OPER_ENTRY was in flux. You could also remove the checks for its value in oper1.g inside INSTALL_METHOD_FLAGS

@ThomasBreuer
Copy link
Contributor Author

Thanks for the hint, @fingolfin. I have now adjusted also methsel.g and oper1.g.

@fingolfin
Copy link
Member

I've adjusted your second commit to work with HPC-GAP. One needs to run make docomp twice, once in a regular GAP build, and once in a HPC-GAP build; the latter is necessary as the difference in oper1.g are controlled by which GAP is running, so we have no choice (with our current tools) than to do it this way.

@ThomasBreuer @fingolfin
Simplify some code dealing with METHODS_OPERATION
d7bf712 
Remove some code which deal with different BASE_SIZE_METHODS_OPER_ENTRY
values. This only matters if one uses a GAP kernel version with a different
GAP library version, which is a bad idea generally.

The resulting code is easier to understand.
@fingolfin fingolfin merged commit b5ea962 into gap-system:master Apr 20, 2021
@ThomasBreuer ThomasBreuer deleted the TB_MethodsOperation branch April 21, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
kind: general proposed change release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasBreuer @fingolfin