CI: detect failure to run make docomp nicely again
#4421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a test for our CI which detects if a PR should have run `make docomp`. But we did not reach it anymore since some changes to `bin/BuildPackages.sh` which added code to use GAP to extract the name of any given packages, by letting GAP print it to stdout and grabbing it from there. But in this particular failure scenario, GAP also printed a warning, which caused `BuildPackages.sh` to fail. This patch suppresses that warning.
fingolfin
added
release notes: not needed
fingolfin
force-pushed
the
mh/fix-docomp-ci
branch
from
3172bd1
to
56715c3
Compare
wilfwilson
approved these changes
Apr 21, 2021
Closed
|
Test: reference #4368 from a regular PR comment |
|
Test: reference #4368 from a regular PR comment again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a test for our CI which detects if a PR should have run
make docomp.But we did not reach it anymore since some changes to
bin/BuildPackages.shwhich added code to use GAP to extract the name of any given packages, by
letting GAP print it to stdout and grabbing it from there. But in this
particular failure scenario, GAP also printed a warning, which caused
BuildPackages.shto fail. This patch suppresses that warning.To verify this works, I am adding a commit which is supposed to trigger this failure mode.
UPDATE: test worked as desired, see e.g. https://github.com/gap-system/gap/runs/2394724252?check_suite_focus=true