-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix printing of strings inside functions #4458
Conversation
Why do we modify the whitespace at all? |
Guessing, I assume it is because we want the String to be a single line, and concatenating the lines together would create huge spaces from indendantion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to do the job nicely, thanks, but I have a question and a suggestion.
11df702
to
ada526c
Compare
There were several issues with this PR, but most of the code disappeared while fixing @fingolfin's comment (as removing formatting removed the indentation I needed to get rid of) |
Previously we normalised all whitespace in printed out functions, which would effect whitespace inside strings.
ada526c
to
575ed3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Previously we normalised all whitespace in printed out functions, which would affect whitespace inside strings.
Previously we would print out functions, then to get rid of all whitespace using
NormalizeWhitespace
. However, this would also normalise whitespace inside strings.