Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: workaround failure to install libzmq3-dev #4468

Merged
merged 1 commit into from
May 7, 2021
Merged

CI: workaround failure to install libzmq3-dev #4468

merged 1 commit into from
May 7, 2021

Conversation

fingolfin
Copy link
Member

See actions/runner-images#3317 for details

@fingolfin fingolfin added release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: ci Anything related to GitHub Actions, Codecov, AppVeyor, Coveralls, Travis, ... labels May 7, 2021
@fingolfin fingolfin force-pushed the mh/workaround-ci-libzmq branch from 1118480 to ed097a2 Compare May 7, 2021 13:30
wilfwilson
wilfwilson approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this Max. According to actions/runner-images#3317 (comment) the PR that caused this problem has been reverted, and so this workaround should (hopefully) become redundant when the next ubuntu-18.04 runner is released.

@wilfwilson wilfwilson merged commit aae2d3e into gap-system:master May 7, 2021
@fingolfin fingolfin deleted the mh/workaround-ci-libzmq branch May 7, 2021 14:23
@fingolfin
Copy link
Member Author

Yeah, it's just not clear to me when that might happen?

@wilfwilson
Copy link
Member

Looking at the recent history of https://github.com/actions/virtual-environments/releases there was a release of the ubuntu-18.04 runner every week or two, because there were releases on:

  • 2021-05-04
  • 2021-04-25
  • 2021-04-19
  • 2021-04-12
  • 2021-04-05

I have subscribed to release notifications on https://github.com/actions/virtual-environments so hopefully I'll get an email when there's a new release.

@wilfwilson
Copy link
Member

Looks like there's a new release imminent, so I'll experiment with removing the workaround soon https://github.com/actions/virtual-environments/releases/tag/ubuntu18%2F20210510.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilfwilson wilfwilson wilfwilson approved these changes

Assignees
No one assigned
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: ci Anything related to GitHub Actions, Codecov, AppVeyor, Coveralls, Travis, ...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fingolfin @wilfwilson