-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all perfect groups of orders $10^6$ till $2*10^6$ #4530
Conversation
Two data files for particular orders are kept separately for individual download, as they are very large. Changed tests whose output now is longer and Manual example cannot run over whole library -- will cause error since not all default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this.
These files seem to be 12.3MB and 51.7MB each, and so I think distributing them separately is a sensible approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition.
By how much does this PR increase the size of the grp
directory (and hence of the GAP distribution)?
"and put it in the `grp` subdirectory of your GAP installation. Then", | ||
" type \n\nreturn;\n\n", | ||
"to continue in this GAP session ", | ||
"(which will read in the file).\n\n\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is indeed reasonable for now, and we can easily replace this with something "better" (whatever that'll mean) once/if we have anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. My first idea for "better" was NrPerfectLibraryGroups could check if the files are available. Back when the perfect groups library had holes in it, I used NrPerfectLibraryGroups to run tests or searches over the library. I agree the current message is very clear and very informative for an interactive session. I followed the instructions, used return
and the search continued without any trouble.
## It contains the perfect groups of order 1975680 | ||
## This data was computed by Alexander Hulpke | ||
## It is distributed under the artistic license 2.0 | ||
## https://opensource.org/licenses/Artistic-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, that's a problem from a legal point of view. Right now we claim "GAP is GPL 2", period, without any differentation. And that's correct at least for core GAP (not for package). This PR changes that. This will require some extra changes. I can help with those, but this is a blocker for a release, IMHO.
It seems to be that the increase in size (for the newly included files in the range |
FWIW, I checked that all of the groups have the claimed order and are perfect. The default method for |
Two data files for particular orders are kept separately for individual
download, as they are very large.