Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make libgap-api.h safe to use from C++ code #4644

Merged

Conversation

MathieuDutSik
Copy link
Contributor

In order to link C libraries to C++ programs, one needs to avoid the mangling.
This is done by adding the *extern "C" {" statements as done in this PR.
This allows to use the libgap in C++ programs with success.

@dimpase dimpase self-assigned this Aug 29, 2021
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

One would also need to create tests for C++ code calling libgap, but it can be done in another PR.

@ChrisJefferson ChrisJefferson merged commit 596bbfc into gap-system:master Aug 30, 2021
@fingolfin fingolfin added the topic: libgap things related to libgap label Feb 25, 2022
@fingolfin fingolfin changed the title Correct libgap-api.h for C++ usage Make libgap-api.h safe to use from C++ code Aug 17, 2022
@fingolfin fingolfin added the release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: libgap things related to libgap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants