kernel: reduce reliance on autoconf defined values (via config.h) in our header files #4678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: kernel
release notes: not needed
No package needs it: float defines its own version (but doesn't use it), CaratInterface has a faux reference, no other distributed package reference it As part of this, replace `task_self` by `mach_task_self`, the name used on macOS. The old name presumably was for use on NeXTStep, which is ancient history.
... instead of only defining our own version of strlcat / strlcpy on systems where they are unavailable. This gets rid of a dependency on config.h in our header files.
Now we only #define it when building HPC-GAP
fingolfin
force-pushed
the
mh/reduce-autoconf-usage-in-headers-sub
branch
from
1282e2f
to
da1a4fe
Compare
wilfwilson
approved these changes
Oct 25, 2021
This was referenced Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of PR #4674 (which in turn is a subset of PR #4492), without the bits that are causing a weird CI failure, so hopefully this PR can be merged quicker.