Remove incorrect line breaks in the output of StringFormatted
#4794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilfwilson
added
gapdays2022-winter
|
@ChrisJefferson As far as you are concerned, does this resolve all of the issues mentioned in #4603? (Are far as I can tell, it does). |
wilfwilson
approved these changes
Feb 24, 2022
|
It fixes the issue of wrapping |
|
Your PR seems to keep the line break hints for me! i.e. #4603 (comment) Is this just a coincidence? |
|
No, you are right, I was just in the wrong branch! |
ChrisJefferson
force-pushed
the
string-formatted
branch
from
5b258a0 to
8982f44
Compare
|
added a test, so now preserving |
fingolfin
approved these changes
Feb 25, 2022
|
Please either edit the PR description to something suitable for the release notes, or mark it as not needing a release notes entry |
ChrisJefferson
changed the title
|
(hopefully useful) release note title |
wilfwilson
changed the title
StringFormatted
wilfwilson
added
the
release notes: use title
wilfwilson
added
the
kind: bug
wilfwilson
changed the title
StringFormattedStringFormatted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringFormatteddelegates toPrintToFormatted, but this means long lines get GAP's automatic line wrapping, so disable that.