More 'make install' progress #4812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
release notes: not needed
fingolfin
force-pushed
the
mh/install-more-partial
branch
from
d4668db
to
97e5e36
Compare
Also split part of it into a separate install-sysinfo target, and refactor how sysinfo.gap is generated. Use this to substantially reduce what is put into the GAP_CPPFLAGS in sysinfo.gap.
fingolfin
force-pushed
the
mh/install-more-partial
branch
from
97e5e36
to
101455b
Compare
ChrisJefferson
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly supersedes PR #4492.
sysinfo.gapgeneration, and improve theinstall-gaproottarget.I think I have a working strategy now for all the previously difficult parts, namely...
sysinfo.gap(implemented in this PR, although it may require further tweaking, which will be revealed once systematic tests are added)gac(see PR Rewritegacto not use libtool #4746; I'll update and complete that once this PR here is merged, as some of the things done here are needed there)config.h(basically already done onmaster:config.his only included by source files now, not headers, so it does not need to be installedThat said, this is still most untested, so a major missing step is to add CI tests for
make installand its parts