kernel: use ffdata.h constants in finite field code #4870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: kernel
release notes: not needed
FriedrichRober
approved these changes
Apr 19, 2022
fingolfin
force-pushed
the
mh/use-ffdata-constants
branch
3 times, most recently
from
cef0491
to
891736d
Compare
This allows us in principle to support values of MAXSIZE_GF_INTERNAL other than 2^16. But even if we never want to do that, it also removes some magic constants from the kernel and arguably makes things more conceptual and clearer. Also adjust a few test cases, and made some error messages consistent between library and kernel.
fingolfin
force-pushed
the
mh/use-ffdata-constants
branch
from
891736d
to
9a20ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us in principle to support values of MAXSIZE_GF_INTERNAL other
than 2^16. But even if we never want to do that, it also removes some magic
constants from the kernel and arguably makes things more conceptual and
clearer.
This is another patch extracted from PR #2997