Improve how Test handles #@exec comments in .tst files (by executing these earlier to allow #@if comments to depend on them)
#5049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
Seem plausible to me. Clarifying the context in which EXPR is evaluated is a very good idea in any case!
Would be good to know what @ChrisJefferson thinks.
fingolfin
added
the
release notes: use title
fingolfin
changed the title
Test handles #@exec comments in .tst files (by executing these earlier to allow #@if comments to depend on them)
fingolfin
added
kind: enhancement
|
This looks good to me. It would be nice to have a test (it's always nice to have a test), but I've checked it works so I'd accept without. |
|
@zickgraf could you please squash the final commit into its parent (so two commits remain) ? I'd normally do this myself, but it seems you turned off the "Allow edits and access to secrets by maintainers" checkbox, so I can't. (Might also wrap the new documentation lines to < 80 characters) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one wants to use code from packages in #@if, one can now load those packages via #@exec.
The first commit fixes some typos.
Text for release notes
see title