Fix AllHomomorphisms regression
#5059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This broke the HAP test suite
fingolfin
added
kind: bug
|
@hulpke does this seem sensible to you? |
fingolfin
changed the title
AllHomomorphisms regression
ThomasBreuer
approved these changes
Sep 21, 2022
|
Backported to stable-4.12 via commit 2cd2903 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that we only checked
IsSolvableGroupto decide whether to callMinimalGeneratingSeton a group. However, in reality this is only implemented for groups in the filterCanEasilyComputePcgs-- thus for perm and pc groups but not for fp groups.This broke the HAP test suite.
This regression was introduced in PR #5032 and is not in GAP 4.12.0, so it also does not need a release notes entry.