Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Display for functions to print where the function was defined, if possible #5139

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Enhance Display for functions to print where the function was defined, if possible #5139

merged 1 commit into from
Oct 20, 2022

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Oct 19, 2022 •
edited
Loading

This is not yet done: while I was updating the tests, I discovered a crash 😂

@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: library release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Oct 19, 2022
@fingolfin
Let Display for functions print where it was defined
b865671 
... at least when that information is available
@fingolfin
Copy link
Member Author

OK the crash seems to have been spurious (it went away after make, seems I forgot to do that after the last pull).

@fingolfin fingolfin marked this pull request as ready for review October 19, 2022 16:46
@fingolfin fingolfin added the gapdays2022-summer Issues and PRs that arose at https://www.gapdays.de/gapdays2022-summer label Oct 19, 2022
@fingolfin fingolfin merged commit 70ace94 into gap-system:master Oct 20, 2022
@fingolfin fingolfin deleted the mh/display-func branch October 20, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisJefferson ChrisJefferson ChrisJefferson approved these changes

@ruthhoffmann ruthhoffmann ruthhoffmann approved these changes

Assignees
No one assigned
Labels
gapdays2022-summer Issues and PRs that arose at https://www.gapdays.de/gapdays2022-summer kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fingolfin @ChrisJefferson @ruthhoffmann