Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildsys: fix out-of-tree cross compiling #5171

Merged
merged 1 commit into from
Oct 27, 2022
Merged

buildsys: fix out-of-tree cross compiling #5171

merged 1 commit into from
Oct 27, 2022

Conversation

fingolfin
Copy link
Member

Cross compiling GAP releases works, as do out-of-tree builds, but the combination unfortunately was broken so far due to some insufficient checks in the code.

@fingolfin
buildsys: fix out-of-tree cross compiling
9692ef3 
Cross compiling GAP releases works, as do out-of-tree builds, but the
combination unfortunately was broken so far due to some insufficient
checks in the code.
@ChrisJefferson
Copy link
Contributor

This looks OK -- would it be reasonable for us to test this in CI? or is it not worth the pain?

@fingolfin
Copy link
Member Author

In principle it would be good; in practice there are a bunch of obstacles: we'd have to test this as part of the release workflow (but this could done, we already have that test); but then we should also do a cross compilation I guess, which seems like a lot more work... Then again perhaps it would suffice to do a normal build and insert a check that certain files are not created, e.g. build/ffdata.c

@fingolfin fingolfin merged commit 45161ef into gap-system:master Oct 27, 2022
@fingolfin fingolfin deleted the mh/out-of-tree-cross-compiler branch October 27, 2022 19:33
@fingolfin
Copy link
Member Author

Backported to stable-4.12 in commit 43096b6

@fingolfin fingolfin added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisJefferson ChrisJefferson ChrisJefferson approved these changes

Assignees
No one assigned
Labels
backport-to-4.12-DONE release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fingolfin @ChrisJefferson