Support package extensions (see the manual section "Extensions Provided by a Package") #5375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBreuer
added
kind: new feature
topic: packages
|
Adding an exhaustive list of supported PackageInfo.g entries somewhere is one of our open issues (It could be in the reference manual, or in a separate "package author guides", or whatever; once it exists, moving it wouldn't be hard either). |
fingolfin
reviewed
Feb 9, 2023
fingolfin
reviewed
Feb 9, 2023
ThomasBreuer
changed the title
fingolfin
approved these changes
Feb 14, 2023
as proposed in issue gap-system#5372
- addresses the comments: changed the `Extensions` format to be a list of records, such that the condition is given by a list of package/version pairs - added a test
- addressed the comments, - added the `Extensions` component to the documented components of `PackageInfo.g`, - improved the description of `PackageInfo.g` (continuing what has been done in gap-system#5376)
ThomasBreuer
force-pushed
the
TB_package_extensions
branch
from
d9d842d
to
e87bce0
Compare
|
The failure of "Wrap releases ..." is due to an inconsistency of https://github.com/gap-system/PackageDistro/releases/download/latest/package-infos.json.gz.sha256 and https://github.com/gap-system/PackageDistro/releases/download/latest/package-infos.json.gz |
fingolfin
approved these changes
Feb 16, 2023
ThomasBreuer
added a commit
to ThomasBreuer/PackageManager
that referenced
this pull request
Feb 17, 2023
The Julia package GAP.jl provides an interface between GAP and Julia. It uses PackageManager for installing and loading GAP packages. As soon as GAP has access to a Julia session, a natural way to download files is via the Julia package Downloads.jl. Therefore, GAP.jl had replaced `PKGMAN_DownloadURL` by a Julia function that uses this approach. Since pull request gap-system/gap#5375 got merged, we can use its new feature such that the PackageManager package can perform this replacement under the condition that GAP.jl is available in the GAP session.
This was referenced Feb 17, 2023
fingolfin
pushed a commit
to gap-packages/PackageManager
that referenced
this pull request
Mar 20, 2023
The Julia package GAP.jl provides an interface between GAP and Julia. It uses PackageManager for installing and loading GAP packages. As soon as GAP has access to a Julia session, a natural way to download files is via the Julia package Downloads.jl. Therefore, GAP.jl had replaced `PKGMAN_DownloadURL` by a Julia function that uses this approach. Since pull request gap-system/gap#5375 got merged, we can use its new feature such that the PackageManager package can perform this replacement under the condition that GAP.jl is available in the GAP session.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature is proposed in issue #5372.
Eventually the feature must be documented.(And the tile must be extended by a link to the relevant manual section, in order to serve as an entry for the release notes.)
Concerning the documentatiion, as far as I understand, it is recommended to add the new component in
PackageInfo.gfiles in thePackageInfo.gfile of the Example package, and to support the component in PackageMaker,but there is no exhaustive list of supported components in
PackageInfo.gfiles in the Reference Manual.