Ensure all lists of lists are marked as rectangular tables when approriate #5450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJefferson
force-pushed
the
table-string-fix
branch
from
78e87e9
to
8bb152f
Compare
fingolfin
reviewed
May 11, 2023
fingolfin
approved these changes
May 11, 2023
|
@ChrisJefferson will you update this? |
ChrisJefferson
force-pushed
the
table-string-fix
branch
from
8bb152f
to
11c4bc2
Compare
fingolfin
added
topic: kernel
kind: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5449
Basically, we were inconsistent on if we treated lists of lists as if they were rectangular tables, depending on what type the inner lists were.
I have tried to very carefully write the code so in the standard cases where everything is a plist of plist, or a plist of not lists, the code is exactly as fast as it used to be -- I tried benchmarking this and I couldn't measure any differences.