Add GAP_IsChar, GAP_IsBoolean, GAP_IsFunction; fix GAP_IsMacFloat; expand some comments
#5457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: enhancement
- `GAP_IsMacFloat` now returns an `int` instead of `Int`, like all the other `GAP_Is*` functions (technically this is an ABI breaking change) - `GAP_IsMacFloat` now also accepts a null pointer - add some comments for functions that are safe to call without catching GAP errors, because they never raise an error (so this is a binding API/ABI promise) - add `GAP_IsChar` (note that technically one could already do this by checking `GAP_ValueOfChar(obj) != -1`)
fingolfin
force-pushed
the
mh/libgap-tweaks
branch
from
f1165e5
to
2ae8a2f
Compare
fingolfin
changed the title
ChrisJefferson
approved these changes
Jun 30, 2023
fingolfin
changed the title
GAP_IsChar, GAP_IsBoolean, GAP_IsFunction; fix GAP_IsMacFloat; expand some comments
fingolfin
added
the
release notes: use title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GAP_IsMacFloatnow returns anintinstead ofInt, like all theother
GAP_Is*functions (technically this is an ABI breaking change)GAP_IsMacFloatnow also accepts a null pointercatching GAP errors, because they never raise an error (so this is
a binding API/ABI promise)
GAP_IsChar(note that technically one could already do thisby checking
GAP_ValueOfChar(obj) != -1)GAP_IsBooleanGAP_IsFunction