Make GroupWithMemory behave more like Group, and e.g. make the wrapped generators immutable, and for matrices try to convert them to a better representation
#5480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBreuer
approved these changes
Aug 8, 2023
In particular, ensure that the wrapped generators are made immutable, and in the case of matrices, possibly converted to a better representation. This is achieved by calling `GroupWithGenerators` on the given generators, and then wrapping the generators of the resulting group. This avoids a surprising mismatch in behavior between ordinary groups and groups with memory in some situations. And of course making the generators immutable prevents further pitfalls. Also make sure we have at least one test for GroupWithMemory where the input is not a group.
fingolfin
force-pushed
the
mh/GroupWithMemory
branch
from
0c6bb89
to
6a8cd88
Compare
|
@ThomasBreuer good suggestion. Also there was a comment which suggested that the input must be a list of generators... so I adjusted that as well... |
fingolfin
changed the title
GroupWithMemory behave more like Group, and e.g. make the wrapped generators immutable, and for matrices try to convert them to a better representation
fingolfin
added
kind: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, ensure that the wrapped generators are made
immutable, and in the case of matrices, possibly converted
to a better representation. This is achieved by calling
GroupWithGeneratorson the given generators, and thenwrapping the generators of the resulting group.
This avoids a surprising mismatch in behavior between
ordinary groups and groups with memory in some situations.
And of course making the generators immutable prevents
further pitfalls.