Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EpimorphismSchurCover with two arguments for p-groups #5501

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Fix EpimorphismSchurCover with two arguments for p-groups #5501

merged 1 commit into from
Sep 4, 2023

Conversation

fingolfin
Copy link
Member

Resolves #5456

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them topic: library release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Sep 1, 2023
@fingolfin fingolfin mentioned this pull request Sep 1, 2023
Closed
ThomasBreuer
ThomasBreuer reviewed Sep 1, 2023
View reviewed changes
lib/schur.gi Outdated Show resolved Hide resolved
ThomasBreuer
ThomasBreuer requested changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This will be o.k. after the fix of the IsTrivial check.

@fingolfin
Copy link
Member Author

@ThomasBreuer please approve if you are happy now :-)

ThomasBreuer
ThomasBreuer approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks.

@ThomasBreuer ThomasBreuer merged commit 9eed734 into gap-system:master Sep 4, 2023
22 checks passed
@fingolfin fingolfin deleted the mh/fix-EpimorphismSchurCover branch September 18, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasBreuer ThomasBreuer ThomasBreuer approved these changes

Assignees
No one assigned
Labels
kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug in EpimorphismSchurCover
2 participants
@fingolfin @ThomasBreuer