Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make License field for GAP packages mandatory #5572

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

fingolfin
Copy link
Member

Resolves #5281

All distributed packages have one, and we want all future distributed packages to have one. The package distribution already enforces this separately.

Of course non-distributed packages can skip it, just like they can skip most other mandatory fields.

@fingolfin fingolfin added topic: packages issues or PRs related to package handling, or specific to a package (for packages w/o issue tracker) release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Jan 10, 2024
Copy link
Contributor

@ChrisJefferson ChrisJefferson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably shouldn't be distributing things without licenses, so this is a clear improvement.

@fingolfin fingolfin merged commit 4db36d7 into gap-system:master Jan 11, 2024
22 checks passed
@fingolfin fingolfin deleted the mh/require-pkg-license branch January 11, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: packages issues or PRs related to package handling, or specific to a package (for packages w/o issue tracker)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change ValidatePackageInfo to require License field
2 participants