Fix failure loading a workspace created while GAP's stdin was a file into a GAP with stdin attached to a terminal #5573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJefferson
approved these changes
Jan 11, 2024
... by reverting a previous change that made us disable readline when stdin is not connected to a terminal (see gap-system#4495). While that still seems useful, and avoids certain issues when piping GAP output into files, it needs a better implication that avoids the issues described in gap-system#5014 Also add a separate CI test suite target "testworkspace" for testing for this issue, and potentially other workspace related issues.
|
Thank you @fingolfin! We are not using workspaces anymore on plesken, so I cannot easily test if this resolves #5014 there. But it looks like the situation is covered by the new tests you added. |
fingolfin
force-pushed
the
mh/fix-workspace
branch
from
61892f1
to
d3f5168
Compare
|
To be clear, without the fix part in this part, the new Unfortunately, it seems that the tests uncovered a new unrelated problem, which causes |
|
opers.tst failure should be fixed now |
fingolfin
force-pushed
the
mh/fix-workspace
branch
from
0d708a1
to
369ba91
Compare
fingolfin
added
kind: bug
fingolfin
changed the title
fingolfin
added
the
release notes: use title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by reverting a previous change that made us disable readline when stdin is not connected to a terminal (see #4495). While that still seems useful, and avoids certain issues when piping GAP output into files, it needs a better implication that avoids the issues described in #5014
Also add a separate CI test suite target "testworkspace" for testing for this issue, and potentially other workspace related issues.
Resolves #5405
Resolves #5014
CC @zickgraf