Fix an error message when computing subgroup lattices of certain insolvable groups #5723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test can become expensive in pcgs of length several hundred, as they might arise in the hybrid quotient algorithm.
Special permgroup method for multiple conjugation tests only applies if the groups are subgroups of the acting one. This fixes gap-system#5717
hulpke
added
kind: bug: unexpected error
fingolfin
approved these changes
May 22, 2024
Comment on lines
+466
to
468
| sub:=ForAll(dom,x->IsSubset(G,x)); | ||
| if n>20 and sub and NrMovedPoints(G)>1000 then | ||
| #and NrMovedPoints(G)*1000>Size(G) then |
There was a problem hiding this comment.
Could also just TryNextMethod here and get rid of sub again shrug
Suggested change
| sub:=ForAll(dom,x->IsSubset(G,x)); | |
| if n>20 and sub and NrMovedPoints(G)>1000 then | |
| #and NrMovedPoints(G)*1000>Size(G) then | |
| if not ForAll(dom,x->IsSubset(G,x)) then TryNextMethod(); fi; | |
| if n>20 and NrMovedPoints(G)>1000 then |
There was a problem hiding this comment.
Yes. This is a fix, and I thus wanted to make the structure as simple and clear as possible. Ultimately I want to be able to get rid of this subset condition again.
fingolfin
changed the title
fingolfin
pushed a commit
that referenced
this pull request
Jun 9, 2024
…lvable groups (#5723) Special permgroup method for multiple conjugation tests only applies if the groups are subgroups of the acting one. Also added an option to cut short abelian test. This test can become expensive in pcgs of length several hundred, as they might arise in the hybrid quotient algorithm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special permgroup method for multiple conjugation tests in
SubgroupsOrbitsAndNormalizersonly applies if the groups are subgroups of the acting one. This fixes #5717Included is a hook to shortcut a test for a subgroup being abelian in
InducedPcgsByGeneratorsNC-- this is relevant for an application with multiple 100s of generators.