Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve transformations code and tests #727

Merged
merged 65 commits into from
Apr 13, 2016

Commits on Apr 11, 2016

  1. Clarified that GAP will exit after the test (noted by Mike Newman)

    Alexander Konovalov authored and james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    04173d9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0575c58 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    801a0e2 View commit details
    Browse the repository at this point in the history
  4. Improve TransformationListListNC

    Better checking of the arguments, and reduce the degree in case the
    defining lists contain trailing fixed points.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    6fedfbc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    87b6ca8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f8f4578 View commit details
    Browse the repository at this point in the history
  7. Improve and cleaning up trans.c 1

    Make functions more robust by checking their args, remove randomness
    from test files, and ensure 100% code coverage.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    f606bad View commit details
    Browse the repository at this point in the history
  8. Whitespace only changes

    Remove trailing whitespace and use uniform code formatting.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    3534852 View commit details
    Browse the repository at this point in the history
  9. Improve and cleaning up trans.c 2

    Make functions more robust by checking their args, remove randomness
    from test files, and ensure 100% code coverage.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    8f824be View commit details
    Browse the repository at this point in the history
  10. Replace the function INDEX_PERIOD_TRANS

    The new method has lower complexity than the old method, which was
    rubbish.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    8a9e157 View commit details
    Browse the repository at this point in the history
  11. Add UNSORTED_IMAGE_SET_TRANS

    To avoid duplicate code.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    0f18f3b View commit details
    Browse the repository at this point in the history
  12. Whitespace only changes

    Remove trailing whitespace and use uniform code formatting.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    1e54e10 View commit details
    Browse the repository at this point in the history
  13. Improve and cleaning up trans.c 3

    Make functions more robust by checking their args, remove randomness
    from test files, and ensure 100% code coverage.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    8ed1bd5 View commit details
    Browse the repository at this point in the history
  14. Whitespace only changes

    Remove trailing whitespace and use uniform code formatting.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    c6ee7c1 View commit details
    Browse the repository at this point in the history
  15. Add return value for UNSORTED_IMAGE_SET_TRANS

    To keep the compiler happy
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    97f8e1f View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    ac42acd View commit details
    Browse the repository at this point in the history
  17. New version of COMPONENT_REPS_TRANS

    The new method is a bit faster and uses less memory.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    123697b View commit details
    Browse the repository at this point in the history
  18. New version of COMPONENTS_TRANS and NR_COMPONENTS_TRANS

    And tests for COMPONENTS_TRANS and NR_COMPONENTS_TRANS. Also update
    NR_COMPONENTS_TRANS to give an error if the arg is not a transformation.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    f36835c View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    631fb0b View commit details
    Browse the repository at this point in the history
  20. Remove redundant code from ON_KERNEL_ANTI_ACTION

    The output of the previous code was not well-defined, or used, so I
    removed it.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    8779428 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    48379dd View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    b271db8 View commit details
    Browse the repository at this point in the history
  23. Fix in the doc

    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    4f62c18 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    1b5e7b2 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    d7441eb View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    9ff2919 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    38601a8 View commit details
    Browse the repository at this point in the history
  28. Rearrange trans.c

    So that functions with related functionality are next to each other, in
    clearly marked sections.
    
    Rename:
      * IMAGE_TRANS -> IMAGE_LIST_TRANS_INT
      * PERM_LEFT_QUO_TRANS_NC -> PermLeftQuoTransformationNC
      * INV_TRANS -> InverseOfTransformation
    
    Remove the GAP versions of the last two, and update the tests.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    41f42f5 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    04814e7 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    0e3bce8 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    ab34cbb View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    68b2b09 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    62a8c80 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    1ed30ac View commit details
    Browse the repository at this point in the history
  35. Reinclude currently unexecutable code

    For the sake of robustness.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    161ec32 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    df3e781 View commit details
    Browse the repository at this point in the history
  37. Fix PowIntTrans2/4

    Remove redundant code, improve error message, and make it so that the
    error can actually be shown. Plus test for this. Also make it so that
    PowIntTrans2/4 work for T_INTPOS.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    ccc95ee View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    59768bb View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    fedd0f4 View commit details
    Browse the repository at this point in the history
  40. Fix OnSetsTrans and add tests

    Previously OnSetsTrans didn't work for T_INTPOS now it does
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    50cba69 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    2abf056 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    2518409 View commit details
    Browse the repository at this point in the history
  43. Refactor TRANS_IMG_CONJ

    To remove duplicate code and to remove the assumption that a T_TRANS4
    always has degree strictly greater than a T_TRANS2.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    c574831 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    a9138d3 View commit details
    Browse the repository at this point in the history
  45. Fix OnTuplesTrans and add tests

    Remove the assumption that we are always acting on immediate positive
    integers, remove incorrect retyping at the end of the function, add an
    error message for lists with unbound entries, and change the condition
    to that holes in lists don't cause a seg fault.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    fc938c0 View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    d32ed90 View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    2f15e98 View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    b76481d View commit details
    Browse the repository at this point in the history
  49. Refactor OnPosIntSetsTrans and add tests

    Removed duplicate code for sorting and removing duplicates, added error
    if the arg is not a transformation.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    504b03e View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    b59df0b View commit details
    Browse the repository at this point in the history
  51. Refactor PermLeftQuoTransformationNC

    To cover all cases and reduce the code length. Previously this included
    the assumption that a T_TRANS4 always has degree strictly greater than a
    T_TRANS2, this commit removes this assumption.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    8972169 View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    f9e6b2d View commit details
    Browse the repository at this point in the history
  53. Add comments and tests for products, quotients, and conjugatation

    And remove some redundant variables.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    04104d6 View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    a9a3521 View commit details
    Browse the repository at this point in the history
  55. Fix corner cases in INDEX_PERIOD_TRANS

    Namely those of the identity, and a permutation.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    7fd36b4 View commit details
    Browse the repository at this point in the history
  56. Configuration menu
    Copy the full SHA
    766e04f View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    0d1ef32 View commit details
    Browse the repository at this point in the history
  58. Remove GAP level versions of C functions

    Remove unnecessary GAP level versions of C functions, and rename the
    C function for:
    
    * RESTRICTED_TRANS -> RestrictedTransformationNC
    * PERM_IMG_TRANS -> PermutationOfImage
    * IS_INJECTIVE_LIST_TRANS -> IsInjectiveListTrans
    * INDEX_PERIOD_TRANS -> IndexPeriodOfTransformation
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    2bf7b94 View commit details
    Browse the repository at this point in the history
  59. Add tests NumberTransformation, TransformationNumber

    and properly check their arguments.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    486dbe0 View commit details
    Browse the repository at this point in the history
  60. Add tests for transformations GAP code

    Remove now redundant code, declarations, fix minor problems, and add
    checks.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    cf55a88 View commit details
    Browse the repository at this point in the history
  61. Remove redundant function RestrictedTransformation

    and rename RestrictedTransformationNC -> RestrictedTransformation, since
    the C function anyway checks its args fully.
    james-d-mitchell committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    91b0be8 View commit details
    Browse the repository at this point in the history
  62. Configuration menu
    Copy the full SHA
    fc6e5c1 View commit details
    Browse the repository at this point in the history
  63. Configuration menu
    Copy the full SHA
    c026d2b View commit details
    Browse the repository at this point in the history
  64. Configuration menu
    Copy the full SHA
    8aa0552 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2016

  1. Remove old tst/teststandard/trans.tst

    This file contains the old tests for transformations.
    james-d-mitchell committed Apr 13, 2016
    Configuration menu
    Copy the full SHA
    9b37e01 View commit details
    Browse the repository at this point in the history