-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve transformations code and tests #727
Commits on Apr 11, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 04173d9 - Browse repository at this point
Copy the full SHA 04173d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0575c58 - Browse repository at this point
Copy the full SHA 0575c58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 801a0e2 - Browse repository at this point
Copy the full SHA 801a0e2View commit details -
Improve TransformationListListNC
Better checking of the arguments, and reduce the degree in case the defining lists contain trailing fixed points.
Configuration menu - View commit details
-
Copy full SHA for 6fedfbc - Browse repository at this point
Copy the full SHA 6fedfbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87b6ca8 - Browse repository at this point
Copy the full SHA 87b6ca8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8f4578 - Browse repository at this point
Copy the full SHA f8f4578View commit details -
Improve and cleaning up trans.c 1
Make functions more robust by checking their args, remove randomness from test files, and ensure 100% code coverage.
Configuration menu - View commit details
-
Copy full SHA for f606bad - Browse repository at this point
Copy the full SHA f606badView commit details -
Remove trailing whitespace and use uniform code formatting.
Configuration menu - View commit details
-
Copy full SHA for 3534852 - Browse repository at this point
Copy the full SHA 3534852View commit details -
Improve and cleaning up trans.c 2
Make functions more robust by checking their args, remove randomness from test files, and ensure 100% code coverage.
Configuration menu - View commit details
-
Copy full SHA for 8f824be - Browse repository at this point
Copy the full SHA 8f824beView commit details -
Replace the function INDEX_PERIOD_TRANS
The new method has lower complexity than the old method, which was rubbish.
Configuration menu - View commit details
-
Copy full SHA for 8a9e157 - Browse repository at this point
Copy the full SHA 8a9e157View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f18f3b - Browse repository at this point
Copy the full SHA 0f18f3bView commit details -
Remove trailing whitespace and use uniform code formatting.
Configuration menu - View commit details
-
Copy full SHA for 1e54e10 - Browse repository at this point
Copy the full SHA 1e54e10View commit details -
Improve and cleaning up trans.c 3
Make functions more robust by checking their args, remove randomness from test files, and ensure 100% code coverage.
Configuration menu - View commit details
-
Copy full SHA for 8ed1bd5 - Browse repository at this point
Copy the full SHA 8ed1bd5View commit details -
Remove trailing whitespace and use uniform code formatting.
Configuration menu - View commit details
-
Copy full SHA for c6ee7c1 - Browse repository at this point
Copy the full SHA c6ee7c1View commit details -
Add return value for UNSORTED_IMAGE_SET_TRANS
To keep the compiler happy
Configuration menu - View commit details
-
Copy full SHA for 97f8e1f - Browse repository at this point
Copy the full SHA 97f8e1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac42acd - Browse repository at this point
Copy the full SHA ac42acdView commit details -
New version of COMPONENT_REPS_TRANS
The new method is a bit faster and uses less memory.
Configuration menu - View commit details
-
Copy full SHA for 123697b - Browse repository at this point
Copy the full SHA 123697bView commit details -
New version of COMPONENTS_TRANS and NR_COMPONENTS_TRANS
And tests for COMPONENTS_TRANS and NR_COMPONENTS_TRANS. Also update NR_COMPONENTS_TRANS to give an error if the arg is not a transformation.
Configuration menu - View commit details
-
Copy full SHA for f36835c - Browse repository at this point
Copy the full SHA f36835cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 631fb0b - Browse repository at this point
Copy the full SHA 631fb0bView commit details -
Remove redundant code from ON_KERNEL_ANTI_ACTION
The output of the previous code was not well-defined, or used, so I removed it.
Configuration menu - View commit details
-
Copy full SHA for 8779428 - Browse repository at this point
Copy the full SHA 8779428View commit details -
Add arg checks and cleanup COMPONENT_TRANS_INT and CYCLE_TRANS_INT
and add tests for these.
Configuration menu - View commit details
-
Copy full SHA for 48379dd - Browse repository at this point
Copy the full SHA 48379ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for b271db8 - Browse repository at this point
Copy the full SHA b271db8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f62c18 - Browse repository at this point
Copy the full SHA 4f62c18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b5e7b2 - Browse repository at this point
Copy the full SHA 1b5e7b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7441eb - Browse repository at this point
Copy the full SHA d7441ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ff2919 - Browse repository at this point
Copy the full SHA 9ff2919View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38601a8 - Browse repository at this point
Copy the full SHA 38601a8View commit details -
So that functions with related functionality are next to each other, in clearly marked sections. Rename: * IMAGE_TRANS -> IMAGE_LIST_TRANS_INT * PERM_LEFT_QUO_TRANS_NC -> PermLeftQuoTransformationNC * INV_TRANS -> InverseOfTransformation Remove the GAP versions of the last two, and update the tests.
Configuration menu - View commit details
-
Copy full SHA for 41f42f5 - Browse repository at this point
Copy the full SHA 41f42f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04814e7 - Browse repository at this point
Copy the full SHA 04814e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e3bce8 - Browse repository at this point
Copy the full SHA 0e3bce8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab34cbb - Browse repository at this point
Copy the full SHA ab34cbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 68b2b09 - Browse repository at this point
Copy the full SHA 68b2b09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62a8c80 - Browse repository at this point
Copy the full SHA 62a8c80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ed30ac - Browse repository at this point
Copy the full SHA 1ed30acView commit details -
Reinclude currently unexecutable code
For the sake of robustness.
Configuration menu - View commit details
-
Copy full SHA for 161ec32 - Browse repository at this point
Copy the full SHA 161ec32View commit details -
Configuration menu - View commit details
-
Copy full SHA for df3e781 - Browse repository at this point
Copy the full SHA df3e781View commit details -
Remove redundant code, improve error message, and make it so that the error can actually be shown. Plus test for this. Also make it so that PowIntTrans2/4 work for T_INTPOS.
Configuration menu - View commit details
-
Copy full SHA for ccc95ee - Browse repository at this point
Copy the full SHA ccc95eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 59768bb - Browse repository at this point
Copy the full SHA 59768bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for fedd0f4 - Browse repository at this point
Copy the full SHA fedd0f4View commit details -
Previously OnSetsTrans didn't work for T_INTPOS now it does
Configuration menu - View commit details
-
Copy full SHA for 50cba69 - Browse repository at this point
Copy the full SHA 50cba69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2abf056 - Browse repository at this point
Copy the full SHA 2abf056View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2518409 - Browse repository at this point
Copy the full SHA 2518409View commit details -
To remove duplicate code and to remove the assumption that a T_TRANS4 always has degree strictly greater than a T_TRANS2.
Configuration menu - View commit details
-
Copy full SHA for c574831 - Browse repository at this point
Copy the full SHA c574831View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9138d3 - Browse repository at this point
Copy the full SHA a9138d3View commit details -
Fix OnTuplesTrans and add tests
Remove the assumption that we are always acting on immediate positive integers, remove incorrect retyping at the end of the function, add an error message for lists with unbound entries, and change the condition to that holes in lists don't cause a seg fault.
Configuration menu - View commit details
-
Copy full SHA for fc938c0 - Browse repository at this point
Copy the full SHA fc938c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d32ed90 - Browse repository at this point
Copy the full SHA d32ed90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f15e98 - Browse repository at this point
Copy the full SHA 2f15e98View commit details -
Configuration menu - View commit details
-
Copy full SHA for b76481d - Browse repository at this point
Copy the full SHA b76481dView commit details -
Refactor OnPosIntSetsTrans and add tests
Removed duplicate code for sorting and removing duplicates, added error if the arg is not a transformation.
Configuration menu - View commit details
-
Copy full SHA for 504b03e - Browse repository at this point
Copy the full SHA 504b03eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b59df0b - Browse repository at this point
Copy the full SHA b59df0bView commit details -
Refactor PermLeftQuoTransformationNC
To cover all cases and reduce the code length. Previously this included the assumption that a T_TRANS4 always has degree strictly greater than a T_TRANS2, this commit removes this assumption.
Configuration menu - View commit details
-
Copy full SHA for 8972169 - Browse repository at this point
Copy the full SHA 8972169View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9e6b2d - Browse repository at this point
Copy the full SHA f9e6b2dView commit details -
Add comments and tests for products, quotients, and conjugatation
And remove some redundant variables.
Configuration menu - View commit details
-
Copy full SHA for 04104d6 - Browse repository at this point
Copy the full SHA 04104d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9a3521 - Browse repository at this point
Copy the full SHA a9a3521View commit details -
Fix corner cases in INDEX_PERIOD_TRANS
Namely those of the identity, and a permutation.
Configuration menu - View commit details
-
Copy full SHA for 7fd36b4 - Browse repository at this point
Copy the full SHA 7fd36b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 766e04f - Browse repository at this point
Copy the full SHA 766e04fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d1ef32 - Browse repository at this point
Copy the full SHA 0d1ef32View commit details -
Remove GAP level versions of C functions
Remove unnecessary GAP level versions of C functions, and rename the C function for: * RESTRICTED_TRANS -> RestrictedTransformationNC * PERM_IMG_TRANS -> PermutationOfImage * IS_INJECTIVE_LIST_TRANS -> IsInjectiveListTrans * INDEX_PERIOD_TRANS -> IndexPeriodOfTransformation
Configuration menu - View commit details
-
Copy full SHA for 2bf7b94 - Browse repository at this point
Copy the full SHA 2bf7b94View commit details -
Add tests NumberTransformation, TransformationNumber
and properly check their arguments.
Configuration menu - View commit details
-
Copy full SHA for 486dbe0 - Browse repository at this point
Copy the full SHA 486dbe0View commit details -
Add tests for transformations GAP code
Remove now redundant code, declarations, fix minor problems, and add checks.
Configuration menu - View commit details
-
Copy full SHA for cf55a88 - Browse repository at this point
Copy the full SHA cf55a88View commit details -
Remove redundant function RestrictedTransformation
and rename RestrictedTransformationNC -> RestrictedTransformation, since the C function anyway checks its args fully.
Configuration menu - View commit details
-
Copy full SHA for 91b0be8 - Browse repository at this point
Copy the full SHA 91b0be8View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc6e5c1 - Browse repository at this point
Copy the full SHA fc6e5c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c026d2b - Browse repository at this point
Copy the full SHA c026d2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8aa0552 - Browse repository at this point
Copy the full SHA 8aa0552View commit details
Commits on Apr 13, 2016
-
Remove old tst/teststandard/trans.tst
This file contains the old tests for transformations.
Configuration menu - View commit details
-
Copy full SHA for 9b37e01 - Browse repository at this point
Copy the full SHA 9b37e01View commit details